On 07/16/2013 08:48 PM, Julián Landerreche wrote:
> Thinking a little more about this, I'd dare to say: the dhcp_domain_add
> function might be ditched without remorse. After r36943 changeset, it seems
> it's not currently used any more. Also, after reading & re-reading the
> dnsmasq man page a few times, I'd dare to say that it doesn't make too much
> sense to set an "--address=/domain/ip" for a 'domain' config in OpenWRT.
>
> Why would someone want to resolve the domain for the whole LAN (ie.
> ".localnet" to a particular host in the LAN?
> Of course, I may be missing something not so obvious here.
>
Hi Julian.
I tested your patch and I like it a lot. It removes, as you point out, the
need for supplementing 'host' configs with additional 'domain' configs.
But there is still some value to 'domain' configs.
For instance, for devices with static IP addresses on the LAN which you want to
be able resolve internally, or for blacklisting certain external sites, i.e.
config domain
option name 'www.yahoo.com.'
option ip '127.0.0.99'
or to some other invalid/unroutable IP address.
So while I like your functionality, I don't think it completely deprecates the
config 'domain'.
-Philip
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
