Hi,
That is a really long Subject line I guess.
On Fri, Nov 22, 2013 at 07:57:21PM +0100, Bastian Bittorf wrote:
>
> Signed-off-by: Bastian Bittorf <bitt...@bluebottle.com>
> ---
> package/base-files/files/sbin/hotplug-call | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/base-files/files/sbin/hotplug-call
> b/package/base-files/files/sbin/hotplug-call
> index c848701..6050180 100755
> --- a/package/base-files/files/sbin/hotplug-call
> +++ b/package/base-files/files/sbin/hotplug-call
> @@ -13,6 +13,6 @@ USER=root
> export PATH LOGNAME USER
> export DEVICENAME="${DEVPATH##*/}"
>
> -for script in /etc/hotplug.d/$1/* ; do (
> - [ -f $script ] && . $script
> -); done
> +for script in /etc/hotplug.d/$1/* ; do
> + [ -f $script ] && ( . $script )
Looks like most of them `exit` for a reason. Maybe we could instead just
document explicitly the way hotplug scripts are run and let scripts take the
shortcut `exit` at appropriate time.
root@TL-WR720N:/# grep -rn 'exit' /etc/hotplug.d/
/etc/hotplug.d/firmware/10-ath9k-eeprom:5: exit 1
/etc/hotplug.d/firmware/10-ath9k-eeprom:30:[ -e /lib/firmware/$FIRMWARE ]
&& exit 0
/etc/hotplug.d/iface/20-firewall:3:[ "$ACTION" = ifup -o "$ACTION" =
ifupdate ] || exit 0
/etc/hotplug.d/iface/20-firewall:5:/etc/init.d/firewall enabled || exit 0
/etc/hotplug.d/iface/20-firewall:7:fw3 -q network "$INTERFACE" >/dev/null
|| exit 0
/etc/hotplug.d/iface/30-6relay:2:/etc/init.d/6relayd enabled || exit 0
/etc/hotplug.d/iface/30-6relay:3:[ -n "$INTERFACE" -a "$ACTION" !=
"ifupdate" ] || exit 0
/etc/hotplug.d/net/10-ar922x-led-fix:17:if [ -z $phyname -o $ACTION !=
"add" ]; then exit 0; fi
/etc/hotplug.d/net/10-ar922x-led-fix:51:exit 0
> +done
> --
> 1.7.2.5
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
