Hey Rafał,

Rafał Miłecki <zaj...@gmail.com> writes:
> +     char ld_preload[64] = {}; /* Has to be big enough for all cases */
...
> +             if (ld_preload[0])
> +                     strcat(ld_preload, ":");
> +             strcat(ld_preload, "/lib/libpreload-seccomp.so");

I understand C is often like that but still using strcat here makes me
feel uneasy. Proper range-checking would require a bit more code, but
it's a one-time coding/reviewing and a neglectable runtime cost.

> +static void __attribute__((constructor)) setnbf(void)
> +{
> +     setbuf(stdout, NULL);
> +}

Not sure if no buffering or line buffering would be the best choice
here.

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercer...@gmail.com
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to