Hi Christian,

I wrote the bash version because of issues in the past with C implementations
of firmware packers for the Meraki routers (mkmerakifw.c and mkmerakifw-old.c).
The issue there was that the main dev was coming from a sysadmin background
and as with many OpenWrt users he had problems with C (endiannes!).

As for what implementation is better. Why not let Karl Palsson (or any
other commentor that wants to join ;) ) decide?

I didn't want to start a race here, I was just more comfortable with finishing my C implementation as i have a problem with understanding such shell-scripts.

From my understanding your linked script fixed the issues? I'm not sure why the script in OpenWRT is that old. IIRC i took it directly from your tree without further modifications.

Note: The NBG6617 isn't the only device from ZyXEL that utilize the ras image.
In fact, the "original" version of the notes above was written by Benjamin Berg
and can still be found as a rather long comment in the NBG6616 image generation
code under /target/linux/ar71xx/image/generic.mk [0]. (And there is at least
one more device that can make use of ras: the NBG6817).

So chances are, there that whatever "wins" will need to be updated to support
those routers as well.

Good point (didn't thought about that). At first glance the NBG6817 looks identical while the NBG6616 is missing the kernel-header part. I will see how i can support those two devices. There is also the NBG6716 around, but his one is using legacy build-code. So for this patch i see it as out-of-scope (although the header looks identical to the NBG6616).

Best wishes
David

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to