Hi On 2018-08-21, Jo-Philipp Wich wrote: > Hi, > > > RAS_VERSION := "V1.99(OWRT.$$(shell echo $(REVISION) | sed s/^r//))C0"
While this passes the version check, the appended git hash does break later on in the flashing process - so at the moment only the numerical revision (of DISTRIB_REVISION='r7890-40eb9bda44') seems to be safe: RAS_VERSION := "V1.99(OWRT.$$(shell echo $(REVISION) | sed -e s/^r// -e s/\\-.*//))C0" # hexdump -C /dev/mmcblk0p6 00000000 00 00 b4 bc 01 47 18 00 56 31 2e 39 39 28 4f 57 |.....G..V1.99(OW| 00000010 52 54 2e 37 38 39 30 29 43 30 00 ff ff ff ff ff |RT.7890)C0......| 00000020 ff ff ff ff ff ff ff ff 00 00 d4 1d 4e 42 47 36 |............NBG6| 00000030 38 31 37 00 ff ff ff ff ff ff ff ff ff ff ff ff |817.............| 00000040 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................| * 00000060 ff ff ff ff ff ff ff ff ff ff ff ff 00 00 98 e5 |................| 00000070 00 40 00 00 ff ff ff ff ff ff ff ff ff ff ff ff |.@..............| 00000080 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................| * 00010000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| * 00100000 > make that RAS_VERSION := "V1.99(OWRT.$(patsubst r%,%,$(REVISION)))C0" > to avoid spawning a shell + sed process. I'll have a look at improving this tonight, thanks. Regards Stefan Lippers-Hollmann _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel