> -----Original Message----- > From: Dmitry Tunin [mailto:hanipouspi...@gmail.com] > Sent: Dienstag, 26. Februar 2019 10:45 > To: Adrian Schmutzler <m...@adrianschmutzler.de> > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: speed up ath9k-eeprom > extraction > > вт, 26 февр. 2019 г. в 02:13, <m...@adrianschmutzler.de>: > > > > Hi Dmitry, > > > > I just sent a bunch of patches based on your initial patch. > > > > Note that your patch is only stored as comment to another and lacks Signed- > off, if I'm not mistaken. > That wasn't my patch. It was a comment to my initial patch as an > opinion how to do it better. >
Ah, now I finally get it. Sorry for the noise. So, since you were first and your real initial patch is tested, I suppose it should be applied. Despite that, some feedback about whether the merging in eeprom.sh is an accepted way to go would be helpful. If no, I would rebase my first patchset (changing dd in-place) on Dmitry's real patch. If yes, either Petr Štetiar can resend his patch proposal or allow me to "take it over", and I go on with my second patchset (moving all to eeprom.sh). What will it be? Best Adrian > > > > > Will try to test all of this during the week. > > > > Best > > > > Adrian > > > > > -----Original Message----- > > > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > > > On Behalf Of Dmitry Tunin > > > Sent: Montag, 25. Februar 2019 19:31 > > > To: Christian Lamparter <chunk...@gmail.com> > > > Cc: Adrian Schmutzler <freif...@adrianschmutzler.de>; Petr Štetiar > > > <yn...@true.cz>; openwrt-devel@lists.openwrt.org > > > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: speed up ath9k-eeprom > > > extraction > > > > > > пн, 25 февр. 2019 г. в 21:20, Christian Lamparter <chunk...@gmail.com>: > > > > > > > > The only problem here is that not all platforms need it. > > > > The problem I always have is more along the way that a patch should > > > > receive some "on-device" testing. So I do look forward for patches > > > > that received a "Tested-by:" tag or has positive replies from > > > > random/unlikely people. But we sadly all know that this system has its > > > limits. > > > > > > In this case mine is really tested on a device if that really matters in > > > this > case;- > > > ) I don't think there can be any problems with this simple approach. > > > > > > Regarding "not all devices" I meant that that eeprom.sh when added to > > > global base-files, will be useless for many platforms. > > > I added DIR-825B1 to ath79 and it needed some hacks to get eeprom and > > > mac, there is no way to upstream this type of methods. But it is an old > > > device. > > > > > > But without these patches many devices have disabled wireless on first > > > boot > > > after flashing, because caldata is not ready in time. Fixing this annoying > > > behavior is important. > > > > > > _______________________________________________ > > > openwrt-devel mailing list > > > openwrt-devel@lists.openwrt.org > > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > _______________________________________________ > > openwrt-devel mailing list > > openwrt-devel@lists.openwrt.org > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
pgpM8C7qn5TuI.pgp
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
