Hi, Tomasz,

On Sat, 20 Feb 2021 at 16:55, Tomasz Maciej Nowak <tmn...@gmail.com> wrote:
>
> The cortexa53 and cortexa72 config refresh are missing, also some symbols 
> could be split from this patch and added to generic config, so other targets 
> refresh will produce smaller diffs. Comments inline.

I have no a53/a72 hardware at all (I only have a9, the Omnia), so any
changes to those targets will be completely untested. Maybe I should
have made this point explicit. :/

[sniped]

> > +# CONFIG_ARCH_MSTARV7 is not set
> Split from this commit and move to generic config.

What do you mean? Split this specific kconfig symbol, or the whole block?

[sniped]

> > +# CONFIG_LEDS_TURRIS_OMNIA is not set
>
> You are adding LEDs node to dts but the driver still is disabled, do the LEDs 
> work without it? If not, make it built-in or package as module.

I'm not adding any features yet. First, I want to get to a point where
the system runs exactly as it would run with 5.4. New features will
come afterwards (in this case, as a module, of course).

[sniped]

Thanks,
Rui

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to