On Fri, 2021-11-12 at 23:46 +0100, Sander Vanheule wrote: > > diff --git > > a/target/linux/realtek/dts-5.10/rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi > > b/target/linux/realtek/dts-5.10/rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi > > new file mode 100644 > > index 0000000000..d41213f1fd > > --- /dev/null > > +++ b/target/linux/realtek/dts-5.10/rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi > > @@ -0,0 +1,216 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > > + > > +#include <dt-bindings/input/input.h> > > +#include <dt-bindings/gpio/gpio.h> > > + > > +/ { > > + chosen { > > + bootargs = "console=ttyS0,9600"; > > + }; > > + > > + memory@0 { > > + device_type = "memory"; > > + reg = <0x0 0x8000000>; > > + }; > > + > > + leds: leds { > > + compatible = "gpio-leds"; > > + > > + any_collision { > > + label = "amber:any_col"; > > Should we start using 'function' and 'color' on 5.10 instead of (or in > addition to) > 'label'? The functions are non-standard, but the #DEFINE-s in led-common.h > are only > strings anyway.
Never mind the "instead of". I forgot it's not possible to properly identify LED nodes for system status if the label property isn't specified. Best, Sander _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel