Hi,
comment below.
Am 4/2/24 um 15:02 schrieb Paul Donald:
Defaults to off.
Only available from >= 1.0.15
These capabilities are sent in TLV.
Signed-off-by: Paul Donald <newtwen+git...@gmail.com>
---
package/network/services/lldpd/files/lldpd.init | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/network/services/lldpd/files/lldpd.init
b/package/network/services/lldpd/files/lldpd.init
index 284c37c2ef..3e804cd033 100644
--- a/package/network/services/lldpd/files/lldpd.init
+++ b/package/network/services/lldpd/files/lldpd.init
@@ -124,6 +124,10 @@ write_lldpd_conf()
local lldp_syscapabilities
config_get lldp_syscapabilities 'config' 'lldp_syscapabilities'
+ # Configurable capabilities in lldpd >= v1.0.15
+ local lldp_capadv
+ config_get_bool lldp_capadv 'config' 'lldp_capadv' 0
Can we at least try to aim for some consistency here? Most preexisting options
are spelled out, even the other capability related option right next does not
abbreviate "capabilities", so this new option should likely be called
"lldp_advcapabilities". Also "adv" is ambiguous, could be interpreted as
"advanced" instead of "advertise" without further context, so consider naming
it "lldp_capability_advertisement" or similar.
~ Jo
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
