On 2024-04-03 01:15, Jo-Philipp Wich wrote: > Hi, > > What's the purpose of this isolated comment? Either we're shipping version >= > v1.0.15 so this code is guaranteed to work or we don't, in which case the > code should not be there. We're not putting such comments next to all other > option handling code either. Evidence that people think in one direction only.
> ~ Jo "What's the purpose of having code review at all?" Comments tell us things. They are *extremely* helpful for those cherry-picking: it is safe to drop such a commit into any older build which has at least that lldpd version. Hope you can see the value in that. _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
