Bernard,
Please try to avoid to duplicate the code. MAC.pm has currently the drawback
of mixing GUI code and library code... i really think it will be more
beneficial to "re-design" MAC.pm and not write again the same kind of code
for the CLI.
If we duplicate the code, it will be very difficult to maintain it.
Thanks,
Le dimanche 21 janvier 2007 17:01, Bernard Li a écrit :
> Here's the main_cli invocation from install_cluster:
>
> if ($ENV{OSCAR_UI} eq "cli")
> {
> $cmd = "./main_cli";
> $cmd = $cmd . " --opkgselector $selector" if $selector;
> $cmd = $cmd . " --buildimage $build" if $build;
> $cmd = $cmd . " --defineclients $define" if $define;
> $cmd = $cmd . " --networkclients $network" if $network;
> $cmd = $cmd . " --bootscript $bootscript" if $bootscript;
> $cmd = $cmd . " $adapter";
> }
>
> So no, not everything is exposed.
>
> What do you guys want to do? Expose all the options of main_cli to
> install_cluster but just not document it?
>
> Another reason why I wanted to call main_cli directly is so that I can
> skip the prereqs setup, sort of like oscar_wizard VS install_cluster.
>
> BTW I'm trying to understand why Wesley didn't re-use the %MAC hash in
> lib/OSCAR/MAC.pm but instead create his own data structure. Currently
> I am adding features like listing MAC associations, assigning to MACs
> only if unassigned and deteting MACs, etc..
>
> Thanks,
>
> Bernard
>
> On 1/21/07, Thomas Naughton <[EMAIL PROTECTED]> wrote:
> > Geoffroy,
> >
> > :) Actually I remember talking to Wesley about this very issue.
> >
> > Yes, access is intended to be via 'install_cluster', with parameters just
> > passed down to 'main_cli'. I don't remember if he passes @ARGV down to
> > 'main_cli' or processes it all at the top-level or not.
> >
> > I mention this, b/c if he does pass @ARGV, then all options should be
> > usable, if you know what is down there, like skipping steps. But I'm
> > pretty sure he only exposes the most basic options to the top-level
> > driver (to avoid confusion by standard users...."i can skip steps in
> > OSCAR?" ... well yes if you know what you're doing).
> >
> > As for sanity-check, I'm not sure but I think we should maintain one
> > entry point (install_cluster) or something like that to simplify things.
> > It also avoids us having to put details like calling santy-check,
> > env-wizard, etc. all over the place.
> >
> > I hope that helps,
> > --tjn
> >
> >
> > _________________________________________________________________________
> > Thomas Naughton [EMAIL PROTECTED]
> > Research Associate (865) 576-4184
> >
> > On Sun, 21 Jan 2007, Geoffroy Vallée wrote:
> > > Hi all,
> > >
> > > Chatting with Bernard, one point about the CLI is not exactly clear .
> > > Are we supposed to use the CLI only via install_cluster? or also using
> > > main_cli? Are all the features provided by main_cli accessible through
> > > install_cluster (like the capability of skipping some steps)? The
> > > documentation does say much about that.
> > > If we can use main_cli directly, we may need to call system-sanity at
> > > the very beginning of the code.
> > >
> > > Thanks,
> > > --
> > > Geoffroy
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share
> your opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Oscar-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/oscar-devel
--
Geoffroy
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Oscar-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/oscar-devel
