Hey,
I do not think we should expose all the options for 'main_cli' at
the top-level. Instead, we should simply pass the @ARGV down to
'main_cli' so it can process anything remaining. This avoids any
confusion by users who might think that the features like "skip" are always
valid, which is not the case and should only be used in certain acceptable
ways. (i.e., advanced feature).
As for the MAC.pm related aspects, I can't speak for Wesley but I'm pretty
sure things were done to avoid interruption and duplication as much as
possible.
Also, I seem to remember that this MAC.pm was initmately tied to the GUI
which had a load of problems. The main thing to remember is that we want
to keep library routines as vanilla as possible in order to keep the same
code path for the GUI & CLI, minus the user interface aspects.
So, if we're doing something specific for the CLI or the GUI that could be
done in a more generic (reusable) manner then please make the changes in
that direction. Otherwise, I think we need to make the effort to think how
we can make things more generic and reusable by both CLI & GUI to make
testing much easier in the long run.
my $0.02,
--tjn
_________________________________________________________________________
Thomas Naughton [EMAIL PROTECTED]
Research Associate (865) 576-4184
On Sun, 21 Jan 2007, Bernard Li wrote:
Here's the main_cli invocation from install_cluster:
if ($ENV{OSCAR_UI} eq "cli")
{
$cmd = "./main_cli";
$cmd = $cmd . " --opkgselector $selector" if $selector;
$cmd = $cmd . " --buildimage $build" if $build;
$cmd = $cmd . " --defineclients $define" if $define;
$cmd = $cmd . " --networkclients $network" if $network;
$cmd = $cmd . " --bootscript $bootscript" if $bootscript;
$cmd = $cmd . " $adapter";
}
So no, not everything is exposed.
What do you guys want to do? Expose all the options of main_cli to
install_cluster but just not document it?
Another reason why I wanted to call main_cli directly is so that I can
skip the prereqs setup, sort of like oscar_wizard VS install_cluster.
BTW I'm trying to understand why Wesley didn't re-use the %MAC hash in
lib/OSCAR/MAC.pm but instead create his own data structure. Currently
I am adding features like listing MAC associations, assigning to MACs
only if unassigned and deteting MACs, etc..
Thanks,
Bernard
On 1/21/07, Thomas Naughton <[EMAIL PROTECTED]> wrote:
Geoffroy,
:) Actually I remember talking to Wesley about this very issue.
Yes, access is intended to be via 'install_cluster', with parameters just
passed down to 'main_cli'. I don't remember if he passes @ARGV down to
'main_cli' or processes it all at the top-level or not.
I mention this, b/c if he does pass @ARGV, then all options should be
usable, if you know what is down there, like skipping steps. But I'm
pretty sure he only exposes the most basic options to the top-level driver
(to avoid confusion by standard users...."i can skip steps in OSCAR?" ...
well yes if you know what you're doing).
As for sanity-check, I'm not sure but I think we should maintain one entry
point (install_cluster) or something like that to simplify things. It also
avoids us having to put details like calling santy-check, env-wizard, etc.
all over the place.
I hope that helps,
--tjn
_________________________________________________________________________
Thomas Naughton [EMAIL PROTECTED]
Research Associate (865) 576-4184
On Sun, 21 Jan 2007, Geoffroy Vall?e wrote:
Hi all,
Chatting with Bernard, one point about the CLI is not exactly clear . Are we
supposed to use the CLI only via install_cluster? or also using main_cli? Are
all the features provided by main_cli accessible through install_cluster
(like the capability of skipping some steps)? The documentation does say much
about that.
If we can use main_cli directly, we may need to call system-sanity at the very
beginning of the code.
Thanks,
--
Geoffroy
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Oscar-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/oscar-devel
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Oscar-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/oscar-devel
