Ok, i will do a review. May there is still a newer version of PSSM on the
other developing system.

cu adrian

2008/5/28 Robert Osfield <[EMAIL PROTECTED]>:

> Hi Adrian,
>
> I forgot to mention, on review I spotted that you'd added a:
>
>  osg::Light* _userLight;
>
> Which raises a red flag, as a possible cause for a dangling pointer to
> be introduced.  A better pointer type would probably be a ref_ptr<> or
> observer_ptr<>.   I have followed up on all the different code paths
> that set/use this pointer so it may be perfect safe, but I thought I'd
> raise a flag now and let you review the code in the context of what
> happens when external objects get deleted.
>
> Robert.
> _______________________________________________
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>



-- 
********************************************
Adrian Egli
_______________________________________________
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to