HI Csaba, I have now reviewed and merged your changes to readFontFile methods to add the use of an optional external Options object. I did change the code though, so that it doesn't clone the Options object passed in but instead passes it directly. Users can subclass from Options and the copy constructor would only copy across the base Options methods so would break this usage model, passing the object straight through fixes this. The problem is that the setting of the caching on fonts is not overridden local so you'll need to do this is calling code if you intend this to happen. I could added the overriding in user specified Options to get round this, but if you didn't intend caching then you'd be stuck.
These changes are now checked, I haven't yet reviewed the changes to the freetype plugin, that is next. I do wonder if we shouldn't be pushing the selection of monochrome to a specific option inbuilt into osgText::Font rather than using Options though. Does freetype itself provide any hints to the type of Font it is? Robert. On 7/1/07, Csaba Halász <[EMAIL PROTECTED]> wrote:
On 7/1/07, Robert Osfield <[EMAIL PROTECTED]> wrote: > > The way to pass extra controls into a plugin is via the > ReaderWriter::Options object that is passed into all calls to > ReaderWriter::read*() methods. The OpenFlight plugin is a good > example of this use of Options. I have added an option named "monochrome". Had to add some extra parameters to functions to allow passing of this. Default values are set so that source code compatibility is ok (I hope). > We could possible store the image data directly as a bitmap. Couldn't find an appropriate GL format, so this is unchanged. I have attached a tgz of the changed files. Is this the preferred way? Let me know what you think. -- Csaba _______________________________________________ osg-users mailing list [email protected] http://openscenegraph.net/mailman/listinfo/osg-users http://www.openscenegraph.org/
_______________________________________________ osg-users mailing list [email protected] http://openscenegraph.net/mailman/listinfo/osg-users http://www.openscenegraph.org/
