On Wed, Aug 21, 2019 at 2:21 PM Waldek Kozaczuk <jwkozac...@gmail.com> wrote:
> Hi, > > Thanks for committing this patch. But unfortunately the tst-huge.so > problem is going to make the unit tests fails. > As bad this is, better one unit failing than a lot of real use cases (which unfortunately none of the unit tests caught) failing. Would be nice to have unit tests trying to run a simple test on a bunch of memory sizes (100MB, 1GB, 1.01 GB, 2GB, 4 GB). This would have caught the previous bugs. > I saw you opened the issue about it. Shall we disable the test until we > fix it or somehow change setup and make this test run with 1GB memory > instead? > I was hoping maybe you were planning to look into this issue, so it will only be a short term problem ;-) If this will become a long-term problem we'll indeed need to do one of the things you suggested - I prefer blacklisting the test in test.py. -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to osv-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/osv-dev/CANEVyjuFrBEf4OwCvOFhTprNsxeGKbXHMZ-U7iYu1RFYtNRaxg%40mail.gmail.com.
