Add a break statement to prevent fall-through from OVS_KEY_ATTR_ETHERNET to
OVS_KEY_ATTR_TUNNEL. Without the break actions setting ethernet addresses fail
to validate with log messages complaining about invalid tunnel attributes.
Fixes: 0a6410fbde ("openvswitch: netlink: support L3 packets")
Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
Acked-by: Pravin B Shelar <pshe...@ovn.org>
Acked-by: Jiri Benc <jb...@redhat.com>
Signed-off-by: Yi Yang <yi.y.y...@intel.com>
---
datapath/flow_netlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
index 08a23b2..6686e67 100644
--- a/datapath/flow_netlink.c
+++ b/datapath/flow_netlink.c
@@ -2090,6 +2090,7 @@ static int validate_set(const struct nlattr *a,
case OVS_KEY_ATTR_ETHERNET:
if (mac_proto != MAC_PROTO_ETHERNET)
return -EINVAL;
+ break;
case OVS_KEY_ATTR_TUNNEL:
#ifndef USE_UPSTREAM_TUNNEL
--
2.1.0
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
