On Tue, Jan 17, 2017 at 12:37:19AM +0000, Yang, Yi Y wrote: > What userspace do "802.1ad patches" depend on? Per Pravin's statement, we > just backport 802.1ad patches to ovs, then the below patch can be applied to > ovs.
Userspace does not yet have support for 802.1ad. I'm still working on it. You can check the list archives for a recent RFC version. I don't know if it's acceptable to backport the datapath (kernel module) support before the userspace support is accepted. If not, you'll have to wait on the userspace. Perhaps Pravin can answer. > commit df30f7408b187929dbde72661c7f7c615268f1d0 > Author: pravin shelar <pshe...@ovn.org> > Date: Mon Dec 26 08:31:27 2016 -0800 > > openvswitch: upcall: Fix vlan handling. > > -----Original Message----- > From: Eric Garver [mailto:e...@erig.me] > Sent: Monday, January 16, 2017 11:01 PM > To: Yang, Yi Y <yi.y.y...@intel.com> > Cc: Pravin Shelar <pshe...@ovn.org>; Jan Scheurich <jan.scheur...@web.de>; > ovs dev <d...@openvswitch.org> > Subject: Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan > frames > > On Mon, Jan 16, 2017 at 02:26:55PM +0000, Yang, Yi Y wrote: > > Hi, Eric > > > > We hope Jiri's L3 patchset can be applied into current ovs because we and > > Ericsson guys are enabling packet_type support and PTAP & non-PTAP based on > > L3 patchset, Pravin said you're backporting your 802.1ad patches from > > net-next to ovs, we don't know when your patches can be posted in ovs-dev, > > I can help with this if you have no time. > > I had replied to Pravin earlier in this thread. > > I do intend to backport the kernel changes to the ovs out-of-tree module. I > was waiting until userspace was ready. Unfortunately that's not likely to > happen this week or even next. > > If you have the time feel free to give it a go. > > > -----Original Message----- > > From: Pravin Shelar [mailto:pshe...@ovn.org] > > Sent: Monday, January 9, 2017 5:33 PM > > To: Yang, Yi Y <yi.y.y...@intel.com>; Eric Garver <e...@erig.me> > > Cc: ovs dev <d...@openvswitch.org>; Jarno Rajahalme <ja...@ovn.org> > > Subject: Re: [PATCH v2 14/17] datapath: Fix skb->protocol for vlan > > frames > > > > On Tue, Jan 3, 2017 at 6:47 AM, Yang, Yi Y <yi.y.y...@intel.com> wrote: > > > Pravin, the issue is current ovs has too many differences from net-next > > > tree, the best way is to apply all the patches before your patch, but it > > > seems a super huge work, it is out of my capability :-) Anybody of you is > > > working on this? > > > > > > > First we need to get 802.1ad patches merged in OVS out of tree module. > > Eric is working on 802.1ad support to OVS. I guess he will backport these > > patches to out of tree kernel module along with the userspace patches. That > > will cover majority of the remaining changes. > > > > Thanks, > > Pravin. > > > > > -----Original Message----- > > > From: Pravin Shelar [mailto:pshe...@ovn.org] > > > Sent: Sunday, January 1, 2017 3:45 PM > > > To: Yang, Yi Y <yi.y.y...@intel.com> > > > Cc: ovs dev <d...@openvswitch.org>; Jarno Rajahalme <ja...@ovn.org> > > > Subject: Re: [PATCH v2 14/17] datapath: Fix skb->protocol for vlan > > > frames > > > > > > On Wed, Dec 28, 2016 at 5:56 PM, Yi Yang <yi.y.y...@intel.com> wrote: > > >> Do not always set skb->protocol to be the ethertype of the L3 header. > > >> For a packet with non-accelerated VLAN tags skb->protocol needs to be > > >> the ethertype of the outermost non-accelerated VLAN ethertype. > > >> > > >> Any VLAN offloading is undone on the OVS netlink interface, and any VLAN > > >> tags added by userspace are non-accelerated, as are double tagged VLAN > > >> packets. > > >> > > >> Fixes: 018c1dda5f ("openvswitch: 802.1AD Flow handling, actions, > > >> vlan parsing, netlink attributes") > > >> Fixes: 5108bbaddc ("openvswitch: add processing of L3 packets") > > >> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> > > >> Signed-off-by: Yi Yang <yi.y.y...@intel.com> > > > This is not upstream patch. So even though it fixes the issue we can not > > > apply it to out of tree kernel module. > > > > > > Can you look at the net branch for the correct patch. > > > > > > Thanks. > > _______________________________________________ > > dev mailing list > > d...@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
