On 02/03/2017 06:26 PM, Daniele Di Proietto wrote: > 2017-02-03 9:38 GMT-08:00 Kevin Traynor <ktray...@redhat.com>: >> On 02/02/2017 08:22 PM, Stokes, Ian wrote: >>>> On 02/02/2017 04:44 PM, Ian Stokes wrote: >>>>> Remove the experimental warning tag in documentation regarding OVS >>>>> deployed via userspace. >>>>> >>>>> Signed-off-by: Ian Stokes <ian.sto...@intel.com> >>>>> --- >>>>> Documentation/intro/install/dpdk.rst | 3 --- >>>>> Documentation/intro/install/userspace.rst | 4 ---- >>>>> NEWS | 2 ++ >>>>> README.rst | 6 +++--- >>>>> 4 files changed, 5 insertions(+), 10 deletions(-) >>>>> >>>>> diff --git a/Documentation/intro/install/dpdk.rst >>>>> b/Documentation/intro/install/dpdk.rst >>>>> index fff0a1a..3018590 100644 >>>>> --- a/Documentation/intro/install/dpdk.rst >>>>> +++ b/Documentation/intro/install/dpdk.rst >>>>> @@ -29,9 +29,6 @@ This document describes how to build and install >>>>> Open vSwitch using a DPDK datapath. Open vSwitch can use the DPDK >>>>> library to operate entirely in userspace. >>>>> >>>>> -.. warning:: >>>>> - The DPDK support of Open vSwitch is considered 'experimental'. >>>>> - >>>>> Build requirements >>>>> ------------------ >>>>> >>>>> diff --git a/Documentation/intro/install/userspace.rst >>>>> b/Documentation/intro/install/userspace.rst >>>>> index 0368527 <sip:0368527>..ebd0c12 100644 >>>>> --- a/Documentation/intro/install/userspace.rst >>>>> +++ b/Documentation/intro/install/userspace.rst >>>>> @@ -34,10 +34,6 @@ This version of Open vSwitch should be built >>>>> manually with ``configure`` and been recently tested, and so Debian >>>>> packages are not a recommended way to use this version of Open vSwitch. >>>>> >>>>> -.. warning:: >>>>> - The userspace-only mode of Open vSwitch is considered experimental. >>>>> It has >>>>> - not been thoroughly tested. >>>>> - >>>>> Building and Installing >>>>> ----------------------- >>>>> >>>>> diff --git a/NEWS b/NEWS >>>>> index 5efcce2..8600f0e 100644 >>>>> --- a/NEWS >>>>> +++ b/NEWS >>>>> @@ -3,6 +3,8 @@ Post-v2.7.0 >>>>> - Tunnels: >>>>> * Added support to set packet mark for tunnel endpoint using >>>>> `egress_pkt_mark` OVSDB option. >>>>> + - Documentation: >>>>> + * OVS deployed in userspace mode no longer tagged as experimental. >>>> >>>> I think this would be a bit clearer. What do you think? >>>> >>>> --- a/NEWS >>>> +++ b/NEWS >>>> @@ -59,4 +59,5 @@ v2.7.0 - xx xxx xxxx >>>> * Removed support for IPsec tunnels. >>>> - DPDK: >>>> + * Removal of experimental tag. >>> >>> We can put it under a DPDK header like you have here, I wonder though is >>> the removal of experimental only relevant to DPDK or do we need to consider >>> OVS userspace without DPDK also? I would think both are well tested at this >>> stage so experimental could be removed for both. Thoughts? >>> >> >> Fine by me. I just want it to be clear that it's removal is for/covers >> the DPDK datapath. > > Thanks for the patch, I'm in favor of the change for DPDK. > > Unless you have a strong reason do to so, I'd prefer to keep the > experimental tag for the userspace datapath without DPDK for the > following reasons: > > * I don't see a lot of valid use cases for it. I think it is > important for testing. > * There's at least a known problem with accessing linux device in > userspace without DPDK for containers with offloads. See > ddcf96d2dcc1("system-tests: Disable offloads in userspace tests.") > > What do you think? >
That sounds good, ACK thanks, Kevin. > Thanks, > > Daniele > >> >>>> >>>> >>>>> >>>>> v2.7.0 - xx xxx xxxx >>>>> --------------------- >>>>> diff --git a/README.rst b/README.rst >>>>> index f5cdaa5..90050e3 100644 >>>>> --- a/README.rst >>>>> +++ b/README.rst >>>>> @@ -38,9 +38,9 @@ following features: >>>>> >>>>> The included Linux kernel module supports Linux 3.10 and up. >>>>> >>>>> -Open vSwitch can also operate, at a cost in performance, entirely in >>>>> userspace, -without assistance from a kernel module. This userspace >>>>> implementation should -be easier to port than the kernel-based switch. >>>> It is considered experimental. >>>>> +Open vSwitch can also operate entirely in userspace without >>>>> +assistance from a kernel module. This userspace implementation >>>>> +should be easier to port than the kernel-based switch. >>>>> >>>>> What's here? >>>>> ------------ >>>>> >>> >> >> _______________________________________________ >> dev mailing list >> d...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev