On Wed, 2017-04-26 at 00:33 +0800, Guoshuai Li wrote: > > > Sure, here it is: > > > > make -C /lib/modules/4.11.0-rc7+/build > > M=/home/gvrose/prj/ovs/datapath/linux modules > > make[4]: Entering directory `/home/gvrose/prj/net-next' > > CC [M] /home/gvrose/prj/ovs/datapath/linux/actions.o > > CC [M] /home/gvrose/prj/ovs/datapath/linux/conntrack.o > > CC [M] /home/gvrose/prj/ovs/datapath/linux/datapath.o > > CC [M] /home/gvrose/prj/ovs/datapath/linux/flow.o > > CC [M] /home/gvrose/prj/ovs/datapath/linux/dp_notify.o > > CC [M] /home/gvrose/prj/ovs/datapath/linux/flow_netlink.o > > /home/gvrose/prj/ovs/datapath/linux/datapath.c: In function > > ‘ovs_flow_cmd_dump’: > > /home/gvrose/prj/ovs/datapath/linux/datapath.c:1368:8: error: too few > > arguments to function ‘genlmsg_parse’ > > OVS_FLOW_ATTR_MAX, flow_policy); > Master branch code is: > err = genlmsg_parse(cb->nlh, &dp_flow_genl_family, a, > OVS_FLOW_ATTR_MAX, flow_policy, NULL); >
In fact I was out of synch with upstream master. Now the compile works fine. I'll add my Reviewed-by: to your original patch. I think since I'm still sort of new to OVS we should get another ACK on it from one of the more experienced developers. Thanks for your work! - Greg > > Please Check in genetlink.h: > > static inline int rpl_genlmsg_parse(const struct nlmsghdr *nlh, > const struct genl_family *family, > struct nlattr *tb[], int maxtype, > const struct nla_policy *policy, > struct netlink_ext_ack *extack) > or > > static inline int rpl_genlmsg_parse(const struct nlmsghdr *nlh, > const struct genl_family *family, > struct nlattr *tb[], int maxtype, > const struct nla_policy *policy) > > > ^ > > In file included > > from /home/gvrose/prj/ovs/datapath/linux/compat/include/net/genetlink.h:7:0, > > from /home/gvrose/prj/ovs/datapath/linux/datapath.c:51: > > ./include/net/genetlink.h:179:19: note: declared here > > static inline int genlmsg_parse(const struct nlmsghdr *nlh, > > ^ > > /home/gvrose/prj/ovs/datapath/linux/flow_netlink.c: In function > > ‘validate_userspace’: > > /home/gvrose/prj/ovs/datapath/linux/flow_netlink.c:2435:6: error: too > > few arguments to function ‘nla_parse_nested’ > > attr, userspace_policy); > Are you in Branch2.7 ? The Code from master branch is not the same as > yours code: > > error = nla_parse_nested(a, OVS_USERSPACE_ATTR_MAX, attr, > userspace_policy, NULL); > > My patch is Base on Master branch. > > > ^ > > In file included > > from /home/gvrose/prj/ovs/datapath/linux/compat/include/net/netlink.h:5:0, > > > > from /home/gvrose/prj/ovs/datapath/linux/compat/include/linux/netlink.h:13, > > from ./include/uapi/linux/neighbour.h:5, > > from ./include/linux/netdevice.h:50, > > > > from /home/gvrose/prj/ovs/datapath/linux/compat/include/linux/netdevice.h:4, > > > > from /home/gvrose/prj/ovs/datapath/linux/flow_netlink.c:22: > > ./include/net/netlink.h:754:19: note: declared here > > static inline int nla_parse_nested(struct nlattr *tb[], int maxtype, > > ^ > > > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
