Lance Richardson <[email protected]> writes: >> From: "Russell Bryant" <[email protected]> >> To: "Ben Pfaff" <[email protected]> >> Cc: "ovs dev" <[email protected]>, "Flavio Leitner" >> <[email protected]>, "Lance Richardson" <[email protected]>, >> "Aaron Conole" <[email protected]> >> Sent: Thursday, 27 April, 2017 3:04:43 PM >> Subject: Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile >> targets. >> >> On Fri, Apr 21, 2017 at 7:01 PM, Ben Pfaff <[email protected]> wrote: >> > On Fri, Mar 31, 2017 at 11:27:23AM -0400, Russell Bryant wrote: >> >> The RPM build makefile targets are helpful during development and testing, >> >> but I personally almost never want the tests to run when I use them. >> >> Leave tests on by default in the spec file for when the package is built >> >> by >> >> distro build systems, but disable it by default in the Makefile targets >> >> and >> >> update the documentation accordingly. >> >> >> >> Signed-off-by: Russell Bryant <[email protected]> >> > >> > I'm OK with this. >> >> Flavio, Lance, Aaron, have any opinions on this? It's not that big of >> a deal. I guess I was feeling both slightly annoyed and lazy that >> day. :-) >> > > Seems fine to me. > > Acked-by: Lance Richardson <[email protected]>
+1 Acked-by: Aaron Conole <[email protected]> >> -- >> Russell Bryant >> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
