On Thu, Apr 27, 2017 at 5:26 PM, Aaron Conole <acon...@redhat.com> wrote: > Lance Richardson <lrich...@redhat.com> writes: > >>> From: "Russell Bryant" <russ...@ovn.org> >>> To: "Ben Pfaff" <b...@ovn.org> >>> Cc: "ovs dev" <d...@openvswitch.org>, "Flavio Leitner" >>> <f...@redhat.com>, "Lance Richardson" <lrich...@redhat.com>, >>> "Aaron Conole" <acon...@redhat.com> >>> Sent: Thursday, 27 April, 2017 3:04:43 PM >>> Subject: Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile >>> targets. >>> >>> On Fri, Apr 21, 2017 at 7:01 PM, Ben Pfaff <b...@ovn.org> wrote: >>> > On Fri, Mar 31, 2017 at 11:27:23AM -0400, Russell Bryant wrote: >>> >> The RPM build makefile targets are helpful during development and >>> >> testing, >>> >> but I personally almost never want the tests to run when I use them. >>> >> Leave tests on by default in the spec file for when the package is built >>> >> by >>> >> distro build systems, but disable it by default in the Makefile targets >>> >> and >>> >> update the documentation accordingly. >>> >> >>> >> Signed-off-by: Russell Bryant <russ...@ovn.org> >>> > >>> > I'm OK with this. >>> >>> Flavio, Lance, Aaron, have any opinions on this? It's not that big of >>> a deal. I guess I was feeling both slightly annoyed and lazy that >>> day. :-) >>> >> >> Seems fine to me. >> >> Acked-by: Lance Richardson <lrich...@redhat.com> > > +1 > > Acked-by: Aaron Conole <acon...@redhat.com>
Thanks, applied to master. -- Russell Bryant _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
