ovn-controller has hundreds of stopwatches and sifting through them to
find which one is showing the performance problem can be tedious and
often involves extra scripting on top of the stopwatch/show output.
This set introduces some ways to filter out the noise directly in the
output of the stopwatch/show:
1. Filter out stopwatches that have no samples, as they are always
zero and only take space on the screen.
2. New option '--threshold/-t' that filters out all the stopwatches
that have their maximums below a certain threshold.
This improves OVN debugging experience.
Also adding some tests to cover the unixctl part of stopwatches that
has no users in OVS and so not really tested today.
Ilya Maximets (3):
stopwatch: Don't show stopwatches with no samples.
stopwatch: Add support for thresholds in the show command.
tests: stopwatch: Add tests for stopwatch unixctl commands.
lib/stopwatch.c | 64 ++++++++++++++++-
tests/automake.mk | 1 +
tests/library.at | 5 --
tests/stopwatch.at | 118 +++++++++++++++++++++++++++++++
tests/test-stopwatch.c | 153 ++++++++++++++++++++++++++++++++++++++++-
tests/testsuite.at | 1 +
6 files changed, 333 insertions(+), 9 deletions(-)
create mode 100644 tests/stopwatch.at
--
2.53.0
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
