On 12 Mar 2026, at 10:24, Ilya Maximets wrote:
> Applications like ovn-controller have hundreds of stopwatches. When
> analyzing performance of different parts of the application you don't
> always know which exact stopwatch to look at, but going over all of
> them manually is tedious. When looking for slowest parts it's useful
> to be able to set a threshold and not show any stopwatches that are
> lower. For example, if the full recompute takes 10 seconds, I'd like
> to look at all the stopwatches that are above 1 second, or something
> like that.
>
> Adding a new parameter for the stopwatch/show that will achieve
> that goal. For example:
>
> ovn-appctl stopwatch/show -t 1000 msec
>
> That will show all stopwatches that had a maximum value above or equal
> to 1000 msec. If the stopwatch is in usec or nsec the threshold will
> be applied properly with the units conversion.
>
> If the units are not provided, then the value will be checked using
> the units of each individual stopwatch. If all the stopwatches are
> in milliseconds, then '-t 10 msec' is equal to '-t 10000 usec',
> '-t 10000000 nsec' or just '-t 10'. Command also accepts the full
> version of the argument - '--threshold'.
>
> There are no users for this functionality in OVS, so there is no
> documentation to update.
>
> Signed-off-by: Ilya Maximets <[email protected]>
Changes look good to me. I guess thanks, on behalf of the OVN community ;)
Acked-by: Eelco Chaudron <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
