Bleep bloop. Greetings Mairtin O'Loingsigh, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: C99 style comment
#121 FILE: ic/ovn-ic.c:864:
//sbrec_port_binding_set_mac(sb_pb, NULL, 0);
WARNING: Line is 96 characters long (recommended limit is 79)
#708 FILE: utilities/ovn-ic-nbctl.8.xml:54:
<dt>[<code>--may-exist</code>] <code>tsp-add</code> <var>switch</var>
<var>port</var></dt>
WARNING: Line is 87 characters long (recommended limit is 79)
#711 FILE: utilities/ovn-ic-nbctl.8.xml:57:
Creates a new transit switch port named <var>port</var> on
<var>switch</var>.
WARNING: Line is 85 characters long (recommended limit is 79)
#715 FILE: utilities/ovn-ic-nbctl.8.xml:61:
Transit switch ports names must be unique. Adding a duplicated name
results
WARNING: Line is 80 characters long (recommended limit is 79)
#728 FILE: utilities/ovn-ic-nbctl.8.xml:74:
<dt><code>tsp-set-addr</code> <var>port</var> [<var>address</var>]...</dt>
WARNING: Line is 99 characters long (recommended limit is 79)
#737 FILE: utilities/ovn-ic-nbctl.8.xml:83:
<dt>an Ethernet address, optionally followed by a space and one or
more IP addresses</dt>
WARNING: Line lacks whitespace around operator
#768 FILE: utilities/ovn-ic-nbctl.c:339:
tsp-add SWITCH PORT add a transit switch PORT\n\
WARNING: Line lacks whitespace around operator
#769 FILE: utilities/ovn-ic-nbctl.c:340:
tsp-set-addr PORT ADDRESS set a transit switch PORT address\n\
WARNING: Line lacks whitespace around operator
#770 FILE: utilities/ovn-ic-nbctl.c:341:
tsp-del PORT delete a transit switch PORT\n\
Lines checked: 1155, Warnings: 8, Errors: 1
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
