On 7/1/26 1:59 PM, David Marchand wrote: > On Mon, 29 Jun 2026 at 18:51, Ilya Maximets <[email protected]> wrote: >> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c >> index 1caac4f6d..18677fba5 100644 >> --- a/lib/dpif-netlink.c >> +++ b/lib/dpif-netlink.c >> @@ -226,12 +226,6 @@ static int ovs_ct_limit_family; >> * Initialized by dpif_netlink_init(). */ >> static unsigned int ovs_vport_mcgroup; >> >> -/* If true, tunnel devices are created using OVS compat/genetlink. >> - * If false, tunnel devices are created with rtnetlink and using light >> weight >> - * tunnels. If we fail to create the tunnel the rtnetlink+LWT, then we >> fallback >> - * to using the compat interface. */ >> -static bool ovs_tunnels_out_of_tree = true; >> - >> static int dpif_netlink_init(void); >> static int open_dpif(const struct dpif_netlink_dp *, struct dpif **); >> static uint32_t dpif_netlink_port_get_pid(const struct dpif *, >> @@ -860,9 +854,7 @@ netdev_to_ovs_vport_type(const char *type) >> >> static int >> dpif_netlink_port_add__(struct dpif_netlink *dpif, const char *name, >> - enum ovs_vport_type type, >> - struct ofpbuf *options, >> - odp_port_t *port_nop) >> + enum ovs_vport_type type, odp_port_t *port_nop) > > We don't need the dpif_netlink_port_add__ helper anymore (same with
While it's true that dpif_netlink_port_add__ is only called form a single place and so it's not technically needed, I'd prefer not to embed it into the caller. It's a large function and the caller is not very simple as well, together it would be ~130 line function, which is not great. dpif_netlink_port_add__ does a specific job of adding the port through netlink and figuring out required netlink request structure, so it makes sense to keep it separate for that reason as well. > dpif_netlink_port_del__, but it is not related to the current patch). dpif_netlink_port_del() is a thin wrapper, so it makes sense to remove it. I think, it's worth doing in this patch, so I'll send a v2 for this one. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
