Matteo Perin <[email protected]> writes:
> The commit that introduced the socket unit also added a dh-exec
> line installing it to /lib/systemd/system/. That is redundant, because
> debian/rules already calls:
>
> dh_installsystemd -popenvswitch-switch --name=ovsdb-server
>
> and dh_installsystemd installs debian/<package>.<name>.socket into
> usr/lib/systemd/system/ on its own, in addition to generating the
> enable/start/stop maintainer script fragments the dh-exec line lacked.
>
> Shipping both paths made lintian fail on a merged-/usr system:
>
> E: openvswitch-switch: file-in-root-and-usr already in:
> usr/lib/systemd/system/ovsdb-server.socket
> [lib/systemd/system/ovsdb-server.socket]
>
> Signed-off-by: Matteo Perin <[email protected]>
> ---
> debian/openvswitch-switch.install | 1 -
> 1 file changed, 1 deletion(-)
LGTM - this needs a fixes line when applying:
Fixes: 7e7f5d26f841 ("rhel: Add ovsdb-server.socket unit for systemd socket
activation.")
Reviewed-by: Aaron Conole <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
