On 8/20/26 4:20 PM, Aaron Conole via dev wrote: > Matteo Perin <[email protected]> writes: > >> The commit that introduced the socket unit also added a dh-exec >> line installing it to /lib/systemd/system/. That is redundant, because >> debian/rules already calls: >> >> dh_installsystemd -popenvswitch-switch --name=ovsdb-server >> >> and dh_installsystemd installs debian/<package>.<name>.socket into >> usr/lib/systemd/system/ on its own, in addition to generating the >> enable/start/stop maintainer script fragments the dh-exec line lacked. >> >> Shipping both paths made lintian fail on a merged-/usr system: >> >> E: openvswitch-switch: file-in-root-and-usr already in: >> usr/lib/systemd/system/ovsdb-server.socket >> [lib/systemd/system/ovsdb-server.socket] >> >> Signed-off-by: Matteo Perin <[email protected]> >> --- >> debian/openvswitch-switch.install | 1 - >> 1 file changed, 1 deletion(-) > > LGTM - this needs a fixes line when applying: > > Fixes: 7e7f5d26f841 ("rhel: Add ovsdb-server.socket unit for systemd socket > activation.") > > Reviewed-by: Aaron Conole <[email protected]>
Looks like it's not actually redundant, as the installation fails in our CI: Failed to start ovs-record-hostname.service: Unit ovsdb-server.socket not found. Could not execute systemctl: at /usr/bin/deb-systemd-invoke line 148. Failed to start openvswitch-switch.service: Unit ovsdb-server.socket not found. https://github.com/ovsrobot/ovs/actions/runs/32359328193/job/96395323298#step:8:4858 Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
