This change does not seem to be all that useful. When rules are constructed, mask and action support do check previously probed support which will be ‘TRUE’.
Another way to see that the below settings are not useful is to set everything to ‘false’ (see below) and run all the system tests in userspace, which will all pass. By the way, the .max_vlan_headers and .max_mpls_headers fields, which I did not change are pretty big numbers and I am fairly sure OVS does not really support that many vlans and labels. static struct odp_support dp_netdev_support = { .max_vlan_headers = SIZE_MAX, .max_mpls_depth = SIZE_MAX, .recirc = false, .ct_state = false, .ct_zone = false, .ct_mark = false, .ct_label = false, .ct_state_nat = false, .ct_orig_tuple = false, .ct_orig_tuple6 = false, }; I think it may be better to clean this up. I can do this if you are ok with that; either way is fine with me. Thanks Darrell On 7/18/17, 11:18 PM, "ovs-dev-boun...@openvswitch.org on behalf of Justin Pettit" <ovs-dev-boun...@openvswitch.org on behalf of jpet...@ovn.org> wrote: The userspace datapath hardcodes support for the features it supports, but it was missing "ct_state_nat", "ct_orig_tuple", and "ct_orig_tuple6". Signed-off-by: Justin Pettit <jpet...@ovn.org> --- lib/dpif-netdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 1dd0d63ebddb..3cd0e95eb0a3 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -112,6 +112,9 @@ static struct odp_support dp_netdev_support = { .ct_zone = true, .ct_mark = true, .ct_label = true, + .ct_state_nat = true, + .ct_orig_tuple = true, + .ct_orig_tuple6 = true, }; /* Stores a miniflow with inline values */ -- 2.7.4 _______________________________________________ dev mailing list d...@openvswitch.org https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=IB5v8vX446JEBsGI6fRh-BZgavpw4tCmjNae3I_Ow8I&s=teWT8FxDJPD0Q3Zc0MbSAz0S4zGTZiN01Zpio7eJzKk&e= _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev