On 19 July 2017 at 14:11, Darrell Ball <dlu...@gmail.com> wrote:
> On Wed, Jul 19, 2017 at 1:18 PM, Darrell Ball <dlu...@gmail.com> wrote:
>> On Wed, Jul 19, 2017 at 12:17 PM, Justin Pettit <jpet...@ovn.org> wrote:
>>> > On Jul 19, 2017, at 10:45 AM, Darrell Ball <db...@vmware.com> wrote:
>>> > On 7/19/17, 8:01 AM, "Justin Pettit" <jpet...@ovn.org> wrote:
>>> >> On Jul 19, 2017, at 2:45 AM, Darrell Ball <db...@vmware.com> wrote:
>>> >> static struct odp_support dp_netdev_support = {
>>> >> .max_vlan_headers = SIZE_MAX,
>>> >> .max_mpls_depth = SIZE_MAX,
>>> >> .recirc = false,
>>> >> .ct_state = false,
>>> >> .ct_zone = false,
>>> >> .ct_mark = false,
>>> >> .ct_label = false,
>>> >> .ct_state_nat = false,
>>> >> .ct_orig_tuple = false,
>>> >> .ct_orig_tuple6 = false,
>>> >> };
>>> >>
>>> >> I think it may be better to clean this up. I can do this if you are ok
>>> with that; either way is fine with me.
>>> >
>>> > I agree that since the datapath features are probed, we should pass
>>> those parameters around instead of using these hardcoded values. However,
>>> it was a more invasive change than I wanted to make at the time, and I'd
>>> want to apply this fix regardless. I was going to add using the probed
>>> values to my to-do list, but I'm happy if you want to take it.
>>> >
>>> > If there is a pressing reason to make a temporary fix, then that is
>>> fine.
>>>
>>> This seems like an obvious fix, and can be safely backported to earlier
>>> version. I agree that feature-probing is a better long-term solution, but
>>> I'd prefer to backport this rather than a bigger change. I would have
>>> proposed this patch anyway.
>>>
>>
>
> [Darrell] Backporting may not apply here as none of Jarno's original tuple
> code made it
> to 2.7
> ///////////////
I think that ct_state_nat was there though, so that bit should
probably be backported.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
