On Fri, Aug 25, 2017 at 06:43:49AM +0800, Yang, Yi wrote: > On Fri, Aug 25, 2017 at 01:39:29AM +0800, Ben Pfaff wrote: > > > do the below changes: > > > > > > 1. change ecanp_nsh and decap_nsh to push_nsh and pop_nsh > > > 2. Use nested OVS_KEY_ATTR_NSH to handle push_nsh. > > > > > > Patch 1 is precisely doing this way. > > > > Since this is targeted at 2.8, I'm only planning to take actual bug > > fixes, or changes that affect Open vSwitch external interfaces where we > > historically maintain a high degree of backward compatibility. > > > > In patch 1, it looks like the change to nsh_hdr_len() is a bug fix. At > > a glance, I am not sure whether any of the other changes in patch 1 are > > bug fixes. > > > > Also in patch 1, renaming and Netlink restructuring isn't a bug fix, > > doesn't appear to affect, say, OpenFlow action names, and it doesn't > > affect any ABIs, so it's not appropriate for 2.8. > > Ok, I'll send patch 1 without datapath actions name change and netlink > change, but it isn't a good result if people see encap_nsh and decep_nsh > in 2.8 and see they are changed to push_nsh and pop_nsh in 2.9 and > later.
It doesn't look to me like these names are changing for OpenFlow actions. Datapath actions are an implementation detail and keeping them 100% stable is not a priority. > > Making 2.8 compliant with the NSH draft makes sense. > > I have finished dec_nsh_ttl action patch, does it make sense for 2.8? You can add that as a patch 3 in the next version and we'll take a look. We want to release 2.8 next week. Thanks, Ben. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev