> -----Original Message----- > From: Markos Chandras [mailto:mchand...@suse.de] > Sent: Tuesday, January 9, 2018 4:23 PM > To: Stokes, Ian <ian.sto...@intel.com>; d...@openvswitch.org > Cc: Kavanagh, Mark B <mark.b.kavan...@intel.com>; Ilya Maximets > <i.maxim...@samsung.com> > Subject: Re: [PATCH branch-2.8] netdev-dpdk: replace uint8_t with > dpdk_port_t > > Hi Ian, > > On 09/01/18 16:16, Stokes, Ian wrote: > >> -----Original Message----- > >> From: Markos Chandras [mailto:mchand...@suse.de] > >> Sent: Tuesday, January 9, 2018 3:55 PM > >> To: d...@openvswitch.org > >> Cc: Kavanagh, Mark B <mark.b.kavan...@intel.com>; Ilya Maximets > >> <i.maxim...@samsung.com>; Stokes, Ian <ian.sto...@intel.com>; Markos > >> Chandras <mchand...@suse.de> > >> Subject: [PATCH branch-2.8] netdev-dpdk: replace uint8_t with > >> dpdk_port_t > >> > >> From: Mark Kavanagh <mark.b.kavan...@intel.com> > >> > >> netdev_dpdk_detach() declares a 'port_id' variable, of type uint8_t. > >> This variable should instead be of type dpdk_port_t. > > > > Hi Markos, is there a specific reason you require this patch back ported > to 2.8? > > No particular reason I just thought to point that out since in other parts > of this file dpdk_port_t is used for the port_id, for example in the > netdev_dpdk_process_devargs() and netdev_dpdk_set_config() functions so > maybe worth fixing these inconsistencies.
Sure, I was just concerned was it fixing a compilation issue or such for you. I've seen it's been applied already and I've given it a quick validation check without issue so no worries. Thanks Ian > > -- > markos > > SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB > 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
