> Hi Ben,
> 
> On 09/01/18 16:56, Ben Pfaff wrote:
> >> Sure, I was just concerned was it fixing a compilation issue or such
> for you. I've seen it's been applied already and I've given it a quick
> validation check without issue so no worries.
> >
> > I interpreted your Signed-off-by as a request to apply it, but I think
> > I must have misunderstood a backport of a patch already on master.  I
> > won't apply it so quickly next time.  I'm learning here too :-)

No problem, I made the same assumption when I first looked at the patch.

> >
> 
> Oh should I have done something different to make it clear that it was a
> backport? I simply took the patch from master, modified the Subject line
> to indicate the branch for the backport and added my SoB line. Might be
> better to use 'cherry-pick -x' for backports to make it more explicit. I
> apologize for any confusion this may have caused

I think the approach you took is the agreed upon approach (specifying the 
branch that the patch is targeted at).

The confusion lay in the sign offs :).

Ian
> 
> --
> markos
> 
> SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB
> 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to