On Tue, Jul 24, 2018 at 07:53 PM GMT, Ben Pfaff wrote: > This has some flaws in the details; for example, command-line options > parsing is very inflexible. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > ---
Thank you for working on this. I hooked it up to ovn-nbct.at test suite and it worked quite nicely. Only test cases that are failing are: 2594: ovn-nbctl - LBs FAILED (ovn-nbctl.at:486) 2595: ovn-nbctl - LBs IPv6 FAILED (ovn-nbctl.at:711) ... because the logging options (-v) are not understood by the daemon. In this case, I think, the option should not be passed in the JSON request. One thing I had to do to get the other tests passing is adjust the format of error messages to match the format of ovn-nbctl regular mode: diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index a1717d153..36ecd3fa7 100644 --- a/ovn/utilities/ovn-nbctl.c +++ b/ovn/utilities/ovn-nbctl.c @@ -147,7 +147,7 @@ main(int argc, char *argv[]) int exit_status; if (cmd_error) { exit_status = EXIT_FAILURE; - fputs(cmd_error, stderr); + fprintf(stderr, "ovn-nbctl: %s", cmd_error); } else { exit_status = EXIT_SUCCESS; fputs(cmd_result, stdout); _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev