On Fri, Aug 03, 2018 at 03:41:55PM +0000, Alin Serdean wrote: > > > > abs_file_name() believed that a file name that begins with / or contains : > > is absolute and that any other file name is relative. On Windows, this is > > wrong in at least the following ways: > > > > * / and \ are interchangeable on Windows. > > > > * A name that begins with \\ or // is also absolute. > > > > * A name that begins with X: but not X:\ is not absolute. > > > > * A name with : in some position other than the second position is > > not absolute (although it might not be valid either?). > > > > Furthermore, Windows has more than one current working directory (one > > per volume letter), so trying to make a file name absolute by just prefixing > > the current working directory for the current volume results in silliness. > > > > This patch attempts to fix the problem. > > > > Found by inspection. > > > > CC: Alin Gabriel Serdean <aserd...@ovn.org> > > Signed-off-by: Ben Pfaff <b...@ovn.org> > [Alin Serdean] Thanks a lot for the change Ben! > I was wondering if you can fold in the following so we can remove even more > confusion:
That is nicer. Thanks, I'll do that. Are the changes to linker flags because PathIsRelative is in some library not previously linked? Or are they independent changes? Thanks, Ben. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
