On Mon, Aug 13, 2018 at 1:04 AM, 0-day Robot <[email protected]> wrote: > > Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Inappropriate bracing around statement > #439 FILE: ovn/lib/inc-proc-eng.h:194: > if (first_run) { \ > > ERROR: Inappropriate bracing around statement > #446 FILE: ovn/lib/inc-proc-eng.h:201: > if (DB_NAME##rec_##TBL_NAME##_table_track_get_first(table)) { \ > > Lines checked: 489, Warnings: 0, Errors: 2 > I don't see a problem here. The bracing is in macro, so has to add " \" after it. Any suggestions? _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
- [ovs-dev] [PATCH v4 00/20] ovn-controller incremental process... Han Zhou
- [ovs-dev] [PATCH v4 02/20] ovsdb-idl.c: Update condition... Han Zhou
- [ovs-dev] [PATCH v4 01/20] ovsdb-idl.c: Remove a mislead... Han Zhou
- [ovs-dev] [PATCH v4 03/20] ovsdb-idlc.in: Support more i... Han Zhou
- [ovs-dev] [PATCH v4 04/20] ovsdb-idl.c: Track changes fo... Han Zhou
- [ovs-dev] [PATCH v4 05/20] ovn-controller: Incremental p... Han Zhou
- Re: [ovs-dev] [ovs-dev, v4, 05 of 20] ovn-controller... 0-day Robot
- Re: [ovs-dev] [ovs-dev, v4, 05 of 20] ovn-contro... Han Zhou
- Re: [ovs-dev] [ovs-dev, v4, 05 of 20] ovn-co... Aaron Conole
- [ovs-dev] [PATCH v4 06/20] ovn-controller: Track OVSDB c... Han Zhou
- [ovs-dev] [PATCH v4 09/20] ovn-controller: runtime_data ... Han Zhou
- [ovs-dev] [PATCH v4 08/20] ovn-controller: Incremental l... Han Zhou
- [ovs-dev] [PATCH v4 10/20] ovn-controller: port-binding ... Han Zhou
- [ovs-dev] [PATCH v4 12/20] ovsdb-idl: Tracking - preserv... Han Zhou
- [ovs-dev] [PATCH v4 11/20] ovn-controller: incremental p... Han Zhou
- [ovs-dev] [PATCH v4 07/20] ovn-controller: Initial use o... Han Zhou
