Han Zhou <[email protected]> writes:
> On Mon, Aug 13, 2018 at 1:04 AM, 0-day Robot <[email protected]> wrote:
>>
>> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your
> patch.
>> Thanks for your contribution.
>>
>> I encountered some error that I wasn't expecting. See the details below.
>>
>>
>> checkpatch:
>> ERROR: Inappropriate bracing around statement
>> #439 FILE: ovn/lib/inc-proc-eng.h:194:
>> if (first_run) { \
>>
>> ERROR: Inappropriate bracing around statement
>> #446 FILE: ovn/lib/inc-proc-eng.h:201:
>> if (DB_NAME##rec_##TBL_NAME##_table_track_get_first(table)) { \
>>
>> Lines checked: 489, Warnings: 0, Errors: 2
>>
> I don't see a problem here. The bracing is in macro, so has to add " \"
> after it. Any suggestions?
None at the moment. It's case we should account for - being in a macro.
It's probably safe to whitelist something like
if ([^\s]) { \
on a line.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
