On Tue, Sep 18, 2018 at 10:19:20AM +0000, Vishal Deep Ajmera wrote:
> > 
> > Thanks for working on making OVS better support IPv6.
> > 
> > The following change stood out to me.  It appears to break ABI compatibility
> > in the kernel datapath.  Is there some reason it's OK?  I especially don't
> > understand why it adds a nested inner struct.
> > 
> Thanks Ben. Yes, the inner structure is not required. Earlier we defined it 
> as union and 
> later changed it to structure. Instead those fields can be simply defined 
> outside of inner 
> structure. I will fix this in v2 patch.

That is good to know, but the inner struct is not the main issue as I
see it.  The main issue is that the change breaks the ABI.  This change
must be implemented in some way that does not break the ABI.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to