> > On Tue, Sep 18, 2018 at 02:53:00PM +0000, Vishal Deep Ajmera wrote: > > > > > > Thanks Ben. Yes, the inner structure is not required. Earlier we > > > > defined it as union and later changed it to structure. Instead > > > > those fields can be simply defined outside of inner structure. I > > > > will fix this in v2 > > > patch. > > > > > > That is good to know, but the inner struct is not the main issue as I see > > > it. > > > The main issue is that the change breaks the ABI. This change must > > > be implemented in some way that does not break the ABI. > > > > Hi Ben, > > Are there any guidelines or mechanism available to extend such > > structures which are defined in openvswitch.h with new fields for supporting > new features? > > > > We primarily need this feature for 'netdev' datapath and so kernel > > implementation need not change. > > Usually, you'd add additional attributes instead of extending existing ones.
Hi Ben, We have restructured the implementation by adding new attribute instead of modifying the existing one, for additional fields needed for this feature. Below is the link of new patch. https://mail.openvswitch.org/pipermail/ovs-dev/2019-January/355053.html Warm Regards, Vishal Ajmera _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
