On 20.02.2019 0:03, Flavio Leitner wrote:
> On Mon, Feb 18, 2019 at 07:00:25PM +0300, Ilya Maximets wrote:
>> Simple test for basic partial HWOL functionality.
>>
>> Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
>> ---
>> tests/dpif-netdev.at | 74 ++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 74 insertions(+)
>>
>> diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at
>> index 6915d43ba..8b30a9573 100644
>> --- a/tests/dpif-netdev.at
>> +++ b/tests/dpif-netdev.at
>> @@ -34,6 +34,18 @@ filter_flow_install () {
>> grep 'flow_add' | sed 's/.*flow_add: //' | sort | uniq
>> }
>>
>> +filter_hw_flow_install () {
>> + grep 'netdev_dummy.*flow put\[create\]' | sed 's/.*|DBG|//' | sort |
>> uniq
>> +}
>> +
>> +filter_hw_flow_del () {
>> + grep 'netdev_dummy.*flow del' | sed 's/.*|DBG|//' | sort | uniq
>> +}
>> +
>> +filter_hw_packet_netdev_dummy () {
>> + grep 'netdev_dummy.*: packet:' | sed 's/.*|DBG|//' | sort | uniq
>
> One minor here, can we include 'with mark:' string in the regex above?
> Or perhaps 'matches with flow' ?
Sure. It's not an issue now because we have no other "packet" logs inside
netdev-dummy, but I agree that it's better to make this function more
specific.
I prepared following incremental:
diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at
index 8b30a9573..039ee971b 100644
--- a/tests/dpif-netdev.at
+++ b/tests/dpif-netdev.at
@@ -43,7 +43,7 @@ filter_hw_flow_del () {
}
filter_hw_packet_netdev_dummy () {
- grep 'netdev_dummy.*: packet:' | sed 's/.*|DBG|//' | sort | uniq
+ grep 'netdev_dummy.*: packet:.*with mark' | sed 's/.*|DBG|//' | sort | uniq
}
filter_flow_dump () {
---
I'll send the v6 with above change later today.
>
> Otherwise LGTM.
Thanks for review and good suggestions.
>
> 1081: dpif-netdev - miss upcall key matches flow_dump - dummy-pmd ok
> 1083: dpif-netdev - partial hw offload - dummy ok
> 1084: dpif-netdev - partial hw offload - dummy-pmd ok
> 1089: PMD - reconfigure n_rxq ok
>
> fbl
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
