On 09.07.2019 11:00, David Marchand wrote: > > > On Tue, Jul 9, 2019 at 9:36 AM Ilya Maximets <i.maxim...@samsung.com > <mailto:i.maxim...@samsung.com>> wrote: > > On 09.07.2019 10:14, David Marchand wrote: > > We can skip the non-PMD thread in this loop for consistency with > dp_netdev_reload_pmd__() if this is what you meant. > > > > But for a non-PMD thread, pmd->reload is set to false at init and is > never touched after this. > > So in this case, this loop is supposed to break right away. > > Hmm. Yes, it seems that you're right. However, I think, it's better to > not wait for non-PMD thread anyway for consistency and better readability. > > > I agree, skipping the non-PMD thread leaves no question on what to expect of > the code. > I will prepare a v4. > > Is there anything else to rework in this series?
All other code looks fine. Looking forward for v4. > > I will be on PTO on thursday evening for 10 days, so I'd like to address any > remaining comment by thursday morning. > > -- > David Marchand _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
