On 12/2/2019 4:25 PM, Ilya Maximets wrote: > BTW, function netdev_dpdk_flow_api_supported() is not intended to be called > in the offloading process. It's only for initialization phase. You can see > the "/* TODO: Check if we able to offload some minimal flow. */" in the code > and that might be destructive and unwanted for offloading process.
I guess the thought you had in mind when writing it was to call rte_flow_validate once or more in order to find out offload capabilities of that device, but for now it is only a comment. In the future if/when we do call rte_flow_validate, I think it should not be in this function, but in a function maybe more specific for that, like netdev_offload_dpdk_cap(), or something like that. In current code for sure, I don't see any issue to call this function in the offloading process, and not only during init. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
