Hi, There is an important use case for having OVS change MAC addresses of dpdk interfaces. OpenStack for example needs to update the MAC address of a VF assigned to a VM, where the corresponding VF representor is owned by dpdk. For some NIC vendors using "ifconfig" or "ip" commands - is not an option (if the NIC is not bifurcated). Therefore OpenStack should use the OVS API to set the MAC address for dpdk interfaces. Along with Ben's explanation it seems right to only allow "internal" or "dpdk" port types to set the MAC.
Testing both patches [1] and [2] - passed successfully. Acked-by: Ophir Munk <ophi...@mellanox.com> I hope patches [1] and [2] can be merged to master. [1] https://patchwork.ozlabs.org/patch/1186896/ ("[ovs-dev,v2] netdev-dpdk: Add ability to set MAC address.") [2] https://patchwork.ozlabs.org/patch/1215075/ ("[ovs-dev,1/1] vswitchd: Allow setting MAC on DPDK interfaces") > -----Original Message----- > From: Ben Pfaff <b...@ovn.org> > Sent: Tuesday, January 7, 2020 2:26 AM > To: Ilya Maximets <i.maxim...@ovn.org> > Cc: Eveline Raine <eveli...@mellanox.com>; d...@openvswitch.org; Moshe > Levi <mosh...@mellanox.com>; Adrian Chiris <adri...@mellanox.com>; > Ophir Munk <ophi...@mellanox.com>; Majd Dibbiny > <m...@mellanox.com>; Roni Bar Yanai <ron...@mellanox.com>; Ameer > Mahagneh <ame...@mellanox.com> > Subject: Re: [PATCH 1/1] vswitchd: Allow setting MAC on DPDK interfaces > > On Fri, Jan 03, 2020 at 03:56:59PM +0100, Ilya Maximets wrote: > > Ben, do you see any other drawbacks that we should handle if we'll > > allow changing MAC addresses for non-internal ports? Or, maybe some > > issues with my logic? > > It can cause surprises for interactions with regular system tools. > Anyone who uses "ip" or "ifconfig" to change the MAC will find it changed > back later (perhaps not immediately). And if you un-set it in the database, > OVS doesn't know what to change it back to. > > These drawbacks aren't there in the same way for devices that OVS "owns" > like internal devices or dpdk devices. Well, I guess they are for OVS > internal > devices to some extent, but for those OVS has some responsibility to pick a > reasonable MAC address to begin with. If OVS doesn't, then it causes > confusion of its own through things like having a machine's MAC address > change if you create a bridge and move a physical NIC onto it. We had lots of > experience with that early on with OVS. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
