On Wed, Nov 4, 2020 at 12:34 PM Ben Pfaff <b...@ovn.org> wrote:
>
> From: Leonid Ryzhyk <lryz...@vmware.com>
>
> Export `ddlog_warn` and `ddlog_err` functions that are just wrappers
> around `VLOG_WARN` and `VLOG_ERR`. This is not ideal because the
> functions are exported by `ovn_util.c` and the resulting log messages use
> `ovn_util` as module name. More importantly, these functions do not do
> log rate limiting.
>
> Signed-off-by: Leonid Ryzhyk <lryz...@vmware.com>
> Signed-off-by: Ben Pfaff <b...@ovn.org>
Acked-by: Numan Siddique <num...@ovn.org>
Thanks
Numan
> ---
> lib/ovn-util.c | 17 +++++++++++++++++
> lib/ovn-util.h | 6 ++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/lib/ovn-util.c b/lib/ovn-util.c
> index abe6b04a7701..eb4f14efffa6 100644
> --- a/lib/ovn-util.c
> +++ b/lib/ovn-util.c
> @@ -722,3 +722,20 @@ ip_address_and_port_from_lb_key(const char *key, char
> **ip_address,
> *addr_family = ss.ss_family;
> return true;
> }
> +
> +#ifdef DDLOG
> +
> +/* Callbacks used by the ddlog northd code to print warnings and errors.
> + */
> +void
> +ddlog_warn(const char *msg)
> +{
> + VLOG_WARN("%s", msg);
> +}
> +
> +void
> +ddlog_err(const char *msg)
> +{
> + VLOG_ERR("%s", msg);
> +}
> +#endif
> diff --git a/lib/ovn-util.h b/lib/ovn-util.h
> index a39cbef5a47e..77d0936a5fbc 100644
> --- a/lib/ovn-util.h
> +++ b/lib/ovn-util.h
> @@ -230,4 +230,10 @@ char *str_tolower(const char *orig);
> bool ip_address_and_port_from_lb_key(const char *key, char **ip_address,
> uint16_t *port, int *addr_family);
>
> +#ifdef DDLOG
> +void ddlog_warn(const char *msg);
> +void ddlog_err(const char *msg);
> +#endif
> +
> +
> #endif
> --
> 2.26.2
>
> _______________________________________________
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
