On 01/04/2021 09:36, Ilya Maximets wrote:
> On 3/31/21 10:05 AM, Mark Gray wrote:
>> When configuring IPsec, "ovs-monitor-ipsec" honours
>> the 'local_ip' option in the 'Interface' table by configuring
>> the 'left' side of the Libreswan connection with 'local_ip'.
>> If 'local_ip' is not specified, "ovs-monitor-ipsec" sets
>> 'left' to '%defaultroute' which is interpreted as the IP
>> address of the default gateway interface.
>>
>> However, when 'remote_ip' is an IPv6 address, Libreswan
>> still interprets '%defaultroute' as the IPv4 address on the
>> default gateway interface (see:
>> https://github.com/libreswan/libreswan/issues/416) giving
>> an "address family inconsistency" error.
>>
>> This patch resolves this issue by specifying the
>> connection as IPv6 when the 'remote_ip' is IPv6 and
>> 'local_ip' has not been set.
>>
>> Signed-off-by: Mark Gray <mark.d.g...@redhat.com>
>> ---
>> v2: refactor address family parsing
>>  ipsec/ovs-monitor-ipsec.in | 35 +++++++++++++++++++++++++++++++++++
>>  1 file changed, 35 insertions(+)
> 
> Beside the comment I made on the previous version, this patch
> looks like a bug fix unlike others in the series.  Is there
> a reason why it placed in the middle of the set?  Does it have
> any dependency on previous patches?
> 

No, I changed the order which should make it easier for your to
backport. I also added a "Fixes" tag.

> Best regards, Ilya Maximets.
> 

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to