Hi Eelco,

Thanks for you comment. My reply is inline.

Cian

> -----Original Message-----
> From: Eelco Chaudron <echau...@redhat.com>
> Sent: Tuesday 29 June 2021 09:25
> To: Ferriter, Cian <cian.ferri...@intel.com>; Van Haaren, Harry 
> <harry.van.haa...@intel.com>
> Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org; Flavio Leitner 
> <f...@sysclose.org>
> Subject: Re: [ovs-dev] [v13 06/12] dpif-netdev: Add command to get dpif 
> implementations.
> 
> 
> 
> On 17 Jun 2021, at 18:18, Cian Ferriter wrote:
> 
> > From: Harry van Haaren <harry.van.haa...@intel.com>
> >
> > This commit adds a new command to retrieve the list of available
> > DPIF implementations. This can be used by to check what implementations
> > of the DPIF are available in any given OVS binary.
> >
> > Usage:
> >  $ ovs-appctl dpif-netdev/dpif-get
> >
> 
> This command only shows the actual available options, not the currently 
> selected ones.
> 
> I think from a support perspective, we need this command to also show the 
> current setting for each
> datapath. Having this only in the log will not work in cases where the log is 
> overwritten.

Yes, good idea. More visibility here is a good suggestion, rather than fishing 
through the logs to see what DPIF is set.

> 
> //Eelco
> 
> Guess this also is true for the MFEX patchset (will reply during my review) 
> and the already included
> “ovs-appctl dpif-netdev/subtable-lookup-prio-get”
> 
> <SNIP>


I'll improve the DPIF get command as per your suggestion. I'm following the 
thread where the DPIF, MFEX and DPCLS get commands are being discussed. I'll 
take the output of this thread into account for the next revision of the 
dpif-impl-get command.

Thread:
https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/384644.html
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to