Hi Harry,
Any Insights on the following 😊
> -----Original Message-----
> From: Flavio Leitner <f...@sysclose.org>
> Sent: Wednesday, June 30, 2021 12:28 AM
> To: Amber, Kumar <kumar.am...@intel.com>
> Cc: d...@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [PATCH] dpif/dpcls: limit count subtable search info
> logs
>
> On Tue, Jun 29, 2021 at 10:19:41PM +0530, Kumar Amber wrote:
> > From: Harry van Haaren <harry.van.haa...@intel.com>
> >
> > This commit avoids many instances of "using subtable X for miniflow (x,y)"
> > in the ovs-vswitchd log when using the DPCLS Autovalidator. This
> > occurs when no specialized subtable is found, and the generic "_any"
> > version of the avx512 subtable search implementation was used. This
> > change logs the subtable usage once, avoiding duplicates.
> >
> > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com>
> > ---
> > lib/dpif-netdev-lookup-avx512-gather.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/dpif-netdev-lookup-avx512-gather.c
> > b/lib/dpif-netdev-lookup-avx512-gather.c
> > index bc359dc4a..f1b44deb3 100644
> > --- a/lib/dpif-netdev-lookup-avx512-gather.c
> > +++ b/lib/dpif-netdev-lookup-avx512-gather.c
> > @@ -411,7 +411,7 @@ dpcls_subtable_avx512_gather_probe(uint32_t
> u0_bits, uint32_t u1_bits)
> > */
> > if (!f && (u0_bits + u1_bits) < (NUM_U64_IN_ZMM_REG * 2)) {
> > f = dpcls_avx512_gather_mf_any;
> > - VLOG_INFO("Using avx512_gather_mf_any for subtable (%d,%d)\n",
> > + VLOG_INFO_ONCE("Using avx512_gather_mf_any for subtable
> > + (%d,%d)\n",
> > u0_bits, u1_bits);
>
> This will log only one time, but there are multiple subtables, so we won't see
> other subtable changing. If the subtable information is not relevant, then it
> shouldn't be in the msg.
>
> Also, the log only exists for *_mf_any, not for others specialized functions.
>
> Do we need that information in runtime? Unless I am missing other callers,
> dpcls_subtable_get_best_impl() has a VLOG_DBG() logging all cases with the
> same information.
>
> --
> fbl
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
