+CC Flavio (Thanks for feedback on V1, this is just FYI, v3 on the way) @Amber; I think a piece of feedback missed from Flavio's suggestion?
" and add a reference to that message in the documentation explaining what that means and how to check other subtables?" Would you add some documentation on how to use the "dump-flows -m" command in this context, and why that output is useful for future optimizations. I think the DPDK Bridges DPCLS section makes most sense, add a sub-section on "Optimizing Specific Subtable Searches", and show the dump flow command there? https://docs.openvswitch.org/en/latest/topics/dpdk/bridge/?highlight=dpdk%20bridge#datapath-classifier-performance Let's review a v3 with those changes, thanks! --- v2: - Update printed message to suggested string > -----Original Message----- > From: Amber, Kumar <kumar.am...@intel.com> > Sent: Thursday, July 8, 2021 9:20 AM > To: ovs-dev@openvswitch.org > Cc: Van Haaren, Harry <harry.van.haa...@intel.com>; Stokes, Ian > <ian.sto...@intel.com> > Subject: [v2] dpif/dpcls: limit count subtable search info logs > > From: Harry van Haaren <harry.van.haa...@intel.com> > > This commit avoids many instances of "using subtable X for miniflow (x,y)" > in the ovs-vswitchd log when using the DPCLS Autovalidator. This occurs > when no specialized subtable is found, and the generic "_any" version of > the avx512 subtable search implementation was used. This change logs the > subtable usage once, avoiding duplicates. > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > --- > lib/dpif-netdev-lookup-avx512-gather.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/dpif-netdev-lookup-avx512-gather.c b/lib/dpif-netdev-lookup- > avx512-gather.c > index bc359dc4a..ced846aa7 100644 > --- a/lib/dpif-netdev-lookup-avx512-gather.c > +++ b/lib/dpif-netdev-lookup-avx512-gather.c > @@ -411,8 +411,8 @@ dpcls_subtable_avx512_gather_probe(uint32_t u0_bits, > uint32_t u1_bits) > */ > if (!f && (u0_bits + u1_bits) < (NUM_U64_IN_ZMM_REG * 2)) { > f = dpcls_avx512_gather_mf_any; > - VLOG_INFO("Using avx512_gather_mf_any for subtable (%d,%d)\n", > - u0_bits, u1_bits); > + VLOG_INFO_ONCE("Using non-specialized AVX512 lookup for subtable" > + " (%d,%d) and possibly others.", u0_bits, u1_bits); > } > > return f; > -- > 2.25.1 _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
