On 8/23/21 10:55 AM, Kumar Amber wrote: > Added 2 separate test-cases for DPCLS and DPIF commands: > > OVS-DPDK unit-tests: > > 9: OVS-DPDK - DPIF Configuration > 10: OVS-DPDK - DPCLS Configuration > > Also updated the validation docs for the same.
Hi. Thanks for working on these tests! AFAICT, these tests doesn't really need to be in the system-dpdk testsuite. I mean, we always have at least 2 implementations: scalar and autovalidator, right? We should be able to test switching between implementations as part of a generic testsuite, i.e. dpif-netdev.at. This way they can be tested as part of CI including the run with AddressSanitizer. And if they are part of a default testsuite, there will be no need to document them separately. Also, enabling of avx512 implementation will not work on systems without avx512 support, so these tests will fail, right? This will not happen for scalar and autovalidator implementations. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
