Hi Kevin, I have updated the V4 with the required changes: http://patchwork.ozlabs.org/project/openvswitch/patch/20210902172346.2389795-1-kumar.am...@intel.com/
More replies are in-lined. Many thanks for the reviews. > -----Original Message----- > From: Kevin Traynor <ktray...@redhat.com> > Sent: Thursday, September 2, 2021 10:40 PM > To: Amber, Kumar <kumar.am...@intel.com>; ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org > Subject: Re: [PATCH v3] pmd.at: Add test-cases for DPCLS and DPIF commands. > > On 26/08/2021 20:57, Kumar Amber wrote: > > Added 2 separate test-cases for DPCLS and DPIF commands: > > 1018: PMD - dpcls configuration > > 1017: PMD - dpif configuration > > > > It might be nicer to describe the test cases a little rather than just list > their title. > Doesn't have to be each individual check - just a line or two describing the > he > purpose of the test. > Included in the v4. > > Signed-off-by: Kumar Amber <kumar.am...@intel.com> > > > > --- > > v3: > > - include comments from Kevin. > > - minor fixes in name and title. > > - include check for get commands. > > - include multiple scenarios for dpcls including max prio, min pro, > > same prio, changing prio and check for each fo them. > > v2: > > - move the test-case to pmd.at from dpdk suit. > > - removed avx512 specific set command as per discussion. > > --- > > tests/pmd.at | 80 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 80 insertions(+) > > > > diff --git a/tests/pmd.at b/tests/pmd.at index 225d4ee3a..19f9d3957 > > 100644 > > --- a/tests/pmd.at > > +++ b/tests/pmd.at > > @@ -1068,3 +1068,83 @@ AT_CHECK([ovs-appctl dpctl/del-dp dummy@dp0], > > [0], [dnl > > > > OVS_VSWITCHD_STOP > > AT_CLEANUP > > + > > +AT_SETUP([PMD - dpif configuration]) > > +OVS_VSWITCHD_START([], [], [], [--dummy-numa 0,0]) > > +AT_CHECK([ovs-vsctl add-port br0 p1 -- set Interface p1 > > +type=dummy-pmd]) > > + > > +AT_CHECK([ovs-vsctl show], [], [stdout]) AT_CHECK([ovs-appctl > > +dpif-netdev/dpif-impl-get | grep "dpif_scalar"], [], [dnl > > + dpif_scalar (pmds: 0) > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/dpif-impl-set dpif_scalar], [0], > > +[dnl DPIF implementation set to dpif_scalar. > > +]) > > + > > +OVS_VSWITCHD_STOP > > +AT_CLEANUP > > + > > +AT_SETUP([PMD - dpcls configuration]) OVS_VSWITCHD_START([], [], [], > > +[--dummy-numa 0,0]) AT_CHECK([ovs-vsctl add-port br0 p1 -- set > > +Interface p1 type=dummy-pmd]) > > + > > +AT_CHECK([ovs-vsctl show], [], [stdout]) AT_CHECK([ovs-appctl > > +dpif-netdev/subtable-lookup-prio-get | grep generic], [], [dnl > > + 1 : generic > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-get | grep > > +autovalidator], [], [dnl > > + 0 : autovalidator > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-set > > +autovalidator 3], [0], [dnl Lookup priority change affected 0 dpcls ports > > and 0 > subtables. > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-get | grep > > +autovalidator], [], [dnl > > + 3 : autovalidator > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-set generic 4], > > +[0], [dnl Lookup priority change affected 0 dpcls ports and 0 subtables. > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-get | grep > > +generic], [], [dnl > > + 4 : generic > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-set generic 8], > > +[0], [dnl Lookup priority change affected 0 dpcls ports and 0 subtables. > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-get | grep > > +generic], [], [dnl > > + 8 : generic > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-set > > +autovalidator 8], [0], [dnl Lookup priority change affected 0 dpcls ports > > and 0 > subtables. > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-get | grep > > +autovalidator], [], [dnl > > + 8 : autovalidator > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-set generic 0], > > +[0], [dnl Lookup priority change affected 0 dpcls ports and 0 subtables. > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-get | grep > > +generic], [], [dnl > > + 0 : generic > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-set generic > > +255], [0], [dnl Lookup priority change affected 0 dpcls ports and 0 > > subtables. > > +]) > > + > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-get | grep > > +generic], [], [dnl > > + 255 : generic > > +]) > > You can check outside the valid range too (a few lines got wrapped in the > email): > Added 2 more scenario to testing one for negative priority and 1 for more than 255. Regards Amber > --- a/tests/pmd.at > +++ b/tests/pmd.at > @@ -1147,4 +1147,26 @@ AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup- > prio-get | grep generic], [], [ > ]) > > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-set generic 256], > +[ignore], [], [dnl error converting priority, use integer in range > +0-255 > +ovs-appctl: ovs-vswitchd: server returned an error > +]) > + > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-get | grep > +generic], [], [dnl > + 255 : generic > +]) > + > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-set generic -1], > +[ignore], [], [dnl error converting priority, use integer in range > +0-255 > +ovs-appctl: ovs-vswitchd: server returned an error > +]) > + > +AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-get | grep > +generic], [], [dnl > + 255 : generic > +]) > + > > Other than that, lgtm. > Kevin. > > > + > > +OVS_VSWITCHD_STOP > > +AT_CLEANUP > > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev