On 11/30/2021 2:06 PM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 11/30/21 10:43, Eli Britstein wrote:
On 11/30/2021 12:31 AM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 11/7/21 11:56, Eli Britstein via dev wrote:
Following dpdk commits [1]-[3], it is now possible to compile with
--enable-Werror. Change the default to on, with an option to disable
using --disable-Werror.
Notes:
1. To compile against 21.11-rc1, need to apply [4] and [5] patches.
2. There are still sparse errors, due to dpdk issue. [6] fixes it.
[1] a3f8d0587188 ("net: avoid cast-align warning in VLAN insert function")
[2] da0333c8790b ("mbuf: avoid cast-align warning in data offset macro")
[3] 6de430b7079e ("eal/x86: avoid cast-align warning in memcpy functions")
[4] https://patchwork.ozlabs.org/project/openvswitch/list/?series=268844
[5] https://patchwork.ozlabs.org/project/openvswitch/list/?series=261231
[6]
https://patches.dpdk.org/project/dpdk/patch/20211028101428.15007-1-david.march...@redhat.com/
Signed-off-by: Eli Britstein <el...@nvidia.com>
Reviewed-by: Gaetan Rivet <gaet...@nvidia.com>
---
.ci/linux-build.sh | 1 -
.cirrus.yml | 2 +-
acinclude.m4 | 4 ++--
3 files changed, 3 insertions(+), 4 deletions(-)
Hi, Eli. I'm not sure if I understand the reason behind this patch.
In linux x86 at least, we had warnings by dpdk. We discussed it in [7], and
fixed some in OVS by [8].
The fixes in dpdk were merged (see above [1]-[3]), so I thought to have this
option by default to prevent future warnings.
Hmm. Maybe it's better to just remove -Wno-cast-align from CI scripts
instead? Current version of a patch will not catch cast-align warnings
in our CI, since they are explicitly disabled.
Hi Ilya,
I cherry-picked my commit on top of the current dpdk-latest/dpdk
branches, that already includes [4]-[6].
Also, I removed the -Wno-cast-align,
https://github.com/elibritstein/OVS/commit/5663a73555ce3c79bf16d2519660bc4fc3e5d8f4,
and pushed for CI.
CI for windows passed, though I do see warnings:
https://ci.appveyor.com/project/elibritstein/ovs/build/job/ejn39u0cr9f42l6c
https://ci.appveyor.com/project/elibritstein/ovs/build/job/emus2vv79ihcd4ng
GitHub actions passed:
https://github.com/elibritstein/OVS/actions/runs/1521686491
Should I squash the removal of -Wno-cast-align and post v2?
What do you suggest next?
Thanks,
Eli
We did encounter some issue on PPC, still pending to a proper resolution, [9].
[7]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fpipermail%2Fovs-dev%2F2021-July%2F384773.html&data=04%7C01%7Celibr%40nvidia.com%7Cfbaf5bb4739649fbbebd08d9b3f9ea57%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637738708996798389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=FA1FbBWhbCa6xaDDIYtWBVSJtLrKXd05SR4Mn4GltSM%3D&reserved=0
[8]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fpipermail%2Fovs-dev%2F2021-July%2F385482.html&data=04%7C01%7Celibr%40nvidia.com%7Cfbaf5bb4739649fbbebd08d9b3f9ea57%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637738708996798389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=YFtFa%2Fzspqp3cABpFb55Cykhg%2Fhpp9plfpSgLxE%2BZUQ%3D&reserved=0
[9]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fpipermail%2Fovs-dev%2F2021-November%2F389381.html&data=04%7C01%7Celibr%40nvidia.com%7Cfbaf5bb4739649fbbebd08d9b3f9ea57%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637738708996798389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=h%2Fl2gxScO%2BYHpEHUjXZjGxQBtLpmv9P4IXjrF4aCV3k%3D&reserved=0
But, in any case, I believe that it will break the Windows build, as
it currently produces a fair amount of warnings.
I admit I haven't tested windows. I tried to look into it, but could not find a
free CI tool for that.
I tried to follow
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.openvswitch.org%2Fen%2Flatest%2Fintro%2Finstall%2Fwindows%2F&data=04%7C01%7Celibr%40nvidia.com%7Cfbaf5bb4739649fbbebd08d9b3f9ea57%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637738708996798389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=4bjVibsMdat27ukfyWX9zUyEPW2%2FhKFHX9EDQXveYjs%3D&reserved=0,
but could not understand what option to choose in
https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.mingw.org%2Fwiki%2FGetting_Started&data=04%7C01%7Celibr%40nvidia.com%7Cfbaf5bb4739649fbbebd08d9b3f9ea57%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637738708996798389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=HlOnsopwilA0WyL3auvhGF5DZlrCadfCyOwLBl%2BJmsY%3D&reserved=0
Could you please advise?
We're using
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.appveyor.com%2F&data=04%7C01%7Celibr%40nvidia.com%7Cfbaf5bb4739649fbbebd08d9b3f9ea57%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637738708996798389%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Opw2Me2j5Yhtp9ivstALHKwJ3XovvJLI6JZo%2Bokv5iw%3D&reserved=0
as a Windows CI. It's free for
public projects. Concurrency is limited to 1 job at a time, but that
should not be a big problem. You should be able to set it up for
yourself. appveyor.yml is included in the OVS repo.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
